[DOP-21634] Make DBReader and DBWriter table name requirements less strict #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
bugfix/DOP-21634
branch
from
f03d936 to
4df3321
Compare
dolfinus
force-pushed
the
bugfix/DOP-21634
branch
from
4df3321 to
ed5836a
Compare
dolfinus
force-pushed
the
bugfix/DOP-21634
branch
from
ed5836a to
2ca7afe
Compare
dolfinus
force-pushed
the
bugfix/DOP-21634
branch
from
2ca7afe to
0dda590
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
+ Coverage 91.67% 91.85% +0.17%
===========================================
Files 225 225
Lines 9649 9649
Branches 987 987
===========================================
+ Hits 8846 8863 +17
+ Misses 608 593 -15
+ Partials 195 193 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
TiGrib
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
DBReader(name=...)andDBWriter(name=...)validators are too strict, and don't allow passing table names with multiple dots. Fixed.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)